Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Virtualenv installation and Emoji Codes Mapping #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

loretoparisi
Copy link

Added requirements.txt for a simpler virtualenv installation with keras default backend (tensorflow) and the mapping of the models classes to the emoji codes in the png.

@bfelbo
Copy link
Owner

bfelbo commented Nov 8, 2017

Thanks for this PR. Can you explain to me why it's needed to add this additional information on how to install using virtualenv? Isn't it fairly clear how to do that with the existing installation information?

The reason I'm asking is that I would like to keep the readme file concise.

@loretoparisi
Copy link
Author

loretoparisi commented Nov 8, 2017

@bfelbo you're welcome! Just my two cents: there are some requirements that are missing or not explicitly written, and also it's good to tell users that using virtualenv is a best practice (see tensorflow installation instruction), etc. A good readme should be good enough for no brainer users as well! Of course it's up to you! thanks for this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants